linux-kernel - Re: [PATCH v2] drm: atmel-hlcdc: Atomic mode-setting conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150209182606.GA11712@gradator.net>
Date:	Mon, 9 Feb 2015 19:26:06 +0100
From:	Sylvain Rochet <sylvain.rochet@...secur.com>
To:	Boris Brezillon <boris.brezillon@...e-electrons.com>
Cc:	David Airlie <airlied@...ux.ie>, dri-devel@...ts.freedesktop.org,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Daniel Vetter <daniel@...ll.ch>
Subject: Re: [PATCH v2] drm: atmel-hlcdc: Atomic mode-setting conversion

Hello Boris,

On Fri, Feb 06, 2015 at 04:22:23PM +0100, Boris Brezillon wrote:
> Convert the HLCDC driver to atomic mode-setting.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
> ---

I am getting the following trace with this patch applied, which seems 
pretty straightforward to fix.

Apart from that, it works perfectly, you can add my:

Tested-by: Sylvain Rochet <sylvain.rochet@...secur.com>



------------[ cut here ]------------
WARNING: CPU: 0 PID: 9 at drivers/clk/clk.c:992 clk_disable+0x28/0x34()
Modules linked in:
CPU: 0 PID: 9 Comm: kworker/0:1 Not tainted 3.19.0-rc7-next-20150204+ #90
Hardware name: Atmel SAMA5 (Device Tree)
Workqueue: events output_poll_execute
[<c0013284>] (unwind_backtrace) from [<c0010f90>] (show_stack+0x10/0x14)
[<c0010f90>] (show_stack) from [<c001b0fc>] (warn_slowpath_common+0x84/0xb0)
[<c001b0fc>] (warn_slowpath_common) from [<c001b1c4>] (warn_slowpath_null+0x1c/0x24)
[<c001b1c4>] (warn_slowpath_null) from [<c0355418>] (clk_disable+0x28/0x34)
[<c0355418>] (clk_disable) from [<c024b1c0>] (atmel_hlcdc_crtc_disable+0xe8/0x114)
[<c024b1c0>] (atmel_hlcdc_crtc_disable) from [<c02209dc>] (__drm_helper_disable_unused_functions+0xa4/0xd8)
[<c02209dc>] (__drm_helper_disable_unused_functions) from [<c0220a24>] (drm_helper_disable_unused_functions+0x14/0x20)
[<c0220a24>] (drm_helper_disable_unused_functions) from [<c022d078>] (drm_fbdev_cma_init+0x78/0xfc)
[<c022d078>] (drm_fbdev_cma_init) from [<c024b7a8>] (atmel_hlcdc_fb_output_poll_changed+0x30/0x40)
[<c024b7a8>] (atmel_hlcdc_fb_output_poll_changed) from [<c0222800>] (output_poll_execute+0x148/0x188)
[<c0222800>] (output_poll_execute) from [<c002bf94>] (process_one_work+0xfc/0x310)
[<c002bf94>] (process_one_work) from [<c002caec>] (worker_thread+0x60/0x478)
[<c002caec>] (worker_thread) from [<c00305b4>] (kthread+0xd4/0xec)
[<c00305b4>] (kthread) from [<c000e4a0>] (ret_from_fork+0x14/0x34)
---[ end trace 9500ebf8d7076b60 ]---
------------[ cut here ]------------
WARNING: CPU: 0 PID: 9 at drivers/clk/clk.c:898 clk_unprepare+0x24/0x2c()
Modules linked in:
CPU: 0 PID: 9 Comm: kworker/0:1 Tainted: G        W      3.19.0-rc7-next-20150204+ #90
Hardware name: Atmel SAMA5 (Device Tree)
Workqueue: events output_poll_execute
[<c0013284>] (unwind_backtrace) from [<c0010f90>] (show_stack+0x10/0x14)
[<c0010f90>] (show_stack) from [<c001b0fc>] (warn_slowpath_common+0x84/0xb0)
[<c001b0fc>] (warn_slowpath_common) from [<c001b1c4>] (warn_slowpath_null+0x1c/0x24)
[<c001b1c4>] (warn_slowpath_null) from [<c03553e8>] (clk_unprepare+0x24/0x2c)
[<c03553e8>] (clk_unprepare) from [<c024b1c8>] (atmel_hlcdc_crtc_disable+0xf0/0x114)
[<c024b1c8>] (atmel_hlcdc_crtc_disable) from [<c02209dc>] (__drm_helper_disable_unused_functions+0xa4/0xd8)
[<c02209dc>] (__drm_helper_disable_unused_functions) from [<c0220a24>] (drm_helper_disable_unused_functions+0x14/0x20)
[<c0220a24>] (drm_helper_disable_unused_functions) from [<c022d078>] (drm_fbdev_cma_init+0x78/0xfc)
[<c022d078>] (drm_fbdev_cma_init) from [<c024b7a8>] (atmel_hlcdc_fb_output_poll_changed+0x30/0x40)
[<c024b7a8>] (atmel_hlcdc_fb_output_poll_changed) from [<c0222800>] (output_poll_execute+0x148/0x188)
[<c0222800>] (output_poll_execute) from [<c002bf94>] (process_one_work+0xfc/0x310)
[<c002bf94>] (process_one_work) from [<c002caec>] (worker_thread+0x60/0x478)
[<c002caec>] (worker_thread) from [<c00305b4>] (kthread+0xd4/0xec)
[<c00305b4>] (kthread) from [<c000e4a0>] (ret_from_fork+0x14/0x34)
---[ end trace 9500ebf8d7076b61 ]--- 


Sylvain
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/