linux-kernel - Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Feb 2015 20:18:44 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Bas Peters <baspeters93@...il.com>
Cc:	Pushpendra Singh <pushpendra.singh@...rtplayin.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	gregkh@...uxfoundation.org, navin.patidar@...il.com,
	gmate.amit@...il.com, manuel.schoelling@....de
Subject: Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error

On Tue, Feb 10, 2015 at 03:27:11PM +0100, Bas Peters wrote:
> >> @@ -101,8 +101,7 @@ void rtl88eu_phy_rf6052_set_cck_txpower(struct adapter *adapt, u8 *powerlevel)
> >>                       ptr++;
> >>               }
> >>       }
> >> -     rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction,
> >> -                                     &pwrtrac_value);
> >> +     rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction, &pwrtrac_value);
> > you are introducing one warning to fix one error. line over 80 character.
> 
> Isn't that warning more of a guideline, rather than an actual warning?
> This seems more readable than:
> 
> -     rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction,
> -                                     &pwrtrac_value);
> +     rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1,
> +
>  &direction, &pwrtrac_value);
CodingStyle says "Statements longer than 80 columns will be broken into sensible chunks,
unless exceeding 80 columns significantly increases readability and does not hide information"

i agree that this is more readable but can it be called significant improvement ? but ofcourse final decision is on Greg.

sudip 
> 
> Bas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/