linux-kernel - Re: [PATCH v3 0/5] Add support for Fujitsu USB host controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54DB43C6.1040605@intel.com>
Date:	Wed, 11 Feb 2015 13:57:58 +0200
From:	Mathias Nyman <mathias.nyman@...el.com>
To:	Sneeker Yeh <sneeker.yeh@...il.com>, Felipe Balbi <balbi@...com>
CC:	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Grant Likely <grant.likely@...aro.org>,
	Huang Rui <ray.huang@....com>,
	Kishon Vijay Abraham I <kishon@...com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	Andy Green <andy.green@...aro.org>,
	Jassi Brar <jaswinder.singh@...aro.org>,
	Sneeker Yeh <Sneeker.Yeh@...fujitsu.com>
Subject: Re: [PATCH v3 0/5] Add support for Fujitsu USB host controller

On 10.02.2015 17:43, Sneeker Yeh wrote:
> Hi
> 
> 2015-01-31 0:38 GMT+08:00 Felipe Balbi <balbi@...com>:
>> Hi,
>>
>> On Thu, Jan 29, 2015 at 10:23:12AM -0600, Felipe Balbi wrote:
>>> On Tue, Jan 27, 2015 at 09:22:50AM -0600, Felipe Balbi wrote:
>>>> Hi,
>>>>
>>>> On Sun, Jan 25, 2015 at 04:13:23PM +0800, Sneeker Yeh wrote:
>>>>> These patches add support for XHCI compliant Host controller found
>>>>> on Fujitsu Socs, and are based on http://lwn.net/Articles/629162/
>>>>> The first patch is to add Fujitsu glue layer of Synopsis DesignWare USB3 driver
>>>>> and last four patch is about quirk implementation of errata in Synopsis
>>>>> DesignWare USB3 IP.
>>>>>
>>>>> Patch 1 introduces a quirk with device disconnection management necessary
>>>>> Synopsys Designware USB3 IP with versions < 3.00a and hardware configuration
>>>>> DWC_USB3_SUSPEND_ON_DISCONNECT_EN=1. It solves a problem where without the
>>>>> quirk, that host controller will die after a usb device is disconnected from
>>>>> port of root hub.
>>>>>
>>>>> Patch 2 is to set Synopsis quirk in xhci platform driver based on xhci platform
>>>>> data.
>>>>>
>>>>> Patch 3 is to add a revison number 2.90a and 3.00a of Synopsis DesignWare USB3
>>>>> IP core driver.
>>>>>
>>>>> Patch 4 introduces using a quirk based on a errata of Synopsis
>>>>> DesignWare USB3 IP which is versions < 3.00a and has hardware configuration
>>>>> DWC_USB3_SUSPEND_ON_DISCONNECT_EN=1, which cannot be read from software. As a
>>>>> result this quirk has to be enabled via platform data or device tree.
>>>>>
>>>>> Patch 5 introduces Fujitsu Specific Glue layer in Synopsis DesignWare USB3 IP
>>>>> driver.
>>>>>
>>>>
>>>> Mathias, let me know how you want to handle this. Either I take them
>>>> all, or you take them all. What do you prefer ?
>>>
>>> Mathias ?
>>
>> Mathias, a reminder on this series.
> 
> Would any problem is still in my patchset?
> e.g. I might still not arrange these patch in a appropriate order so
> that Mathias cannot review and accept these?
> 

Sorry about the delay.
Let me take a better look at the first patch and reasons behind the
race. I want to check if a quirk is enough or if we need to dig deeper into xhci.

I'll try to do it today still

-Mathias

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/