[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAEUsAPbg+-32iidn2+44oYahqmTOnd7Lym2GygjbBDGU00sgXQ@mail.gmail.com>
Date: Wed, 11 Feb 2015 05:58:06 -0600
From: Chris Rorvick <chris@...vick.com>
To: Takashi Iwai <tiwai@...e.de>
Cc: alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
Stefan Hajnoczi <stefanha@...il.com>
Subject: Re: [PATCH 1/6] ALSA: line6: Improve line6_read/write_data() interfaces
On Wed, Feb 11, 2015 at 3:33 AM, Takashi Iwai <tiwai@...e.de> wrote:
> At Tue, 10 Feb 2015 23:03:12 -0600,
> Chris Rorvick wrote:
>>
>> Use explicit types to reflect the range of valid values.
>
> Well, this isn't necessarily to be changed at these places. If we
> want to be safer, there should be proper range checks instead.
> Also, readers may wonder when they see the different types between
> read and write without explanations.
Thanks, I'll send a v2 shortly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists