linux-kernel - Re: [PATCH] spi: fsl-quadspi: cleanup wait_for_completion return handling

Open Source and information security mailing list archives

Message-ID: <CA+EcR23aNNaOEk8kmw7S1MX1uzVdZ=At1q2aAtJh3jNLnyOk7Q@mail.gmail.com>
Date:	Tue, 10 Feb 2015 22:00:01 -0600
From:	Han Xu <xhnjupt@...il.com>
To:	Nicholas Mc Guire <hofrat@...dl.org>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	Marek Vasut <marex@...x.de>, linux-kernel@...r.kernel.org,
	Huang Shijie <b32955@...escale.com>,
	Allen Xu <b45815@...escale.com>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	Brian Norris <computersforpeace@...il.com>,
	Ben Hutchings <ben@...adent.org.uk>
Subject: Re: [PATCH] spi: fsl-quadspi: cleanup wait_for_completion return handling

On Sun, Feb 1, 2015 at 5:15 AM, Nicholas Mc Guire <hofrat@...dl.org> wrote:
> return type of wait_for_completion_timeout is unsigned long not int, this
> patch uses the return value of wait_for_completion_timeout in the condition
> directly rather than adding a additional appropriately typed variable.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
> ---
>
> As the returnvalue of wait_for_completion_timeout is logically treated here
> as a boolean (timeout occured or not) it can be wrapped into the if condition
> directly and no additional variable is needed.
>
> This patch was only compile tested with imx_v6_v7_defconfig
> (implies CONFIG_SPI_FSL_QUADSPI=y)
>
> Patch is against 3.19.0-rc6 -next-20150130
>
>  drivers/mtd/spi-nor/fsl-quadspi.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index a46bea3..2543b5c 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -455,8 +455,7 @@ fsl_qspi_runcmd(struct fsl_qspi *q, u8 cmd, unsigned int addr, int len)
>         writel((seqid << QUADSPI_IPCR_SEQID_SHIFT) | len, base + QUADSPI_IPCR);
>
>         /* Wait for the interrupt. */
> -       err = wait_for_completion_timeout(&q->c, msecs_to_jiffies(1000));
> -       if (!err) {
> +       if (!wait_for_completion_timeout(&q->c, msecs_to_jiffies(1000))) {
>                 dev_err(q->dev,
>                         "cmd 0x%.2x timeout, addr@...x, FR:0x%.8x, SR:0x%.8x\n",
>                         cmd, addr, readl(base + QUADSPI_FR),
> --
> 1.7.10.4
>

Acked-by: Han Xu <han.xu@...escale.com>

>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives