linux-kernel - Re: [PATCH] spi: fsl-quadspi: cleanup wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150331011041.GN32500@ld-irv-0074>
Date:	Mon, 30 Mar 2015 18:10:41 -0700
From:	Brian Norris <computersforpeace@...il.com>
To:	Han Xu <xhnjupt@...il.com>
Cc:	Nicholas Mc Guire <hofrat@...dl.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	Marek Vasut <marex@...x.de>, linux-kernel@...r.kernel.org,
	Huang Shijie <b32955@...escale.com>,
	Allen Xu <b45815@...escale.com>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	Ben Hutchings <ben@...adent.org.uk>
Subject: Re: [PATCH] spi: fsl-quadspi: cleanup wait_for_completion return
 handling

On Tue, Feb 10, 2015 at 10:00:01PM -0600, Han Xu wrote:
> On Sun, Feb 1, 2015 at 5:15 AM, Nicholas Mc Guire <hofrat@...dl.org> wrote:
> > return type of wait_for_completion_timeout is unsigned long not int, this
> > patch uses the return value of wait_for_completion_timeout in the condition
> > directly rather than adding a additional appropriately typed variable.
> >
> > Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
> > ---
> >
> > As the returnvalue of wait_for_completion_timeout is logically treated here
> > as a boolean (timeout occured or not) it can be wrapped into the if condition
> > directly and no additional variable is needed.
> >
> > This patch was only compile tested with imx_v6_v7_defconfig
> > (implies CONFIG_SPI_FSL_QUADSPI=y)
> >
> > Patch is against 3.19.0-rc6 -next-20150130

In practice, I don't think this should matter, since we're not even
close to 2^32 jiffies, but the patch looks fine anyway.

Pushed to l2-mtd.git. Thanks!

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/