linux-kernel - Re: [PATCH 2/4] spi: imx: checkpatch cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1423744938.15343.29.camel@perches.com>
Date:	Thu, 12 Feb 2015 04:42:18 -0800
From:	Joe Perches <joe@...ches.com>
To:	Aurelien BOUIN <a.bouin@...il.com>
Cc:	broonie@...nel.org, festevam@...il.com, linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] spi: imx: checkpatch cleanup

On Thu, 2015-02-12 at 13:07 +0100, Aurelien BOUIN wrote:
> This patch solve various issue detected by checkpatch.pl

trivia:

> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
[]
> @@ -282,7 +282,8 @@ static unsigned int mx51_ecspi_clkdiv(unsigned int fin, unsigned int fspi,
>  		(post << MX51_ECSPI_CTRL_POSTDIV_OFFSET);
>  }
>  
> -static void __maybe_unused mx51_ecspi_intctrl(struct spi_imx_data *spi_imx, int enable)
> +static void __maybe_unused mx51_ecspi_intctrl(struct spi_imx_data *spi_imx,
> +		int enable)

Perhaps it'd be better to use this style:

__maybe_unused
static void foo(...)

ie:

__maybe_unused
static void mx51_ecspi_intctrl(struct spi_imx_data *spi_imx, int enable)

etc..

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/