linux-kernel - [PATCH] Don't leak a key reference if request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150212164531.19850.29188.stgit@warthog.procyon.org.uk>
Date:	Thu, 12 Feb 2015 16:45:31 +0000
From:	David Howells <dhowells@...hat.com>
To:	jmorris@...ei.org
Cc:	dhowells@...hat.com, linux-security-module@...r.kernel.org,
	keyrings@...ux-nfs.org, David Jeffery <djeffery@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] Don't leak a key reference if request_key() tries to use a
 revoked keyring

From: David Jeffery <djeffery@...hat.com>

If a request_key() call to allocate and fill out a key attempts to insert the
key structure into a revoked keyring, the key will leak, using memory and part
of the user's key quota until the system reboots. This is from a failure of
construct_alloc_key() to decrement the key's reference count after the attempt
to insert into the requested keyring is rejected.

key_put() needs to be called in the link_prealloc_failed callpath to ensure
the unused key is released.

Signed-off-by: David Jeffery <djeffery@...hat.com>
Signed-off-by: David Howells <dhowells@...hat.com>
---

 security/keys/request_key.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/security/keys/request_key.c b/security/keys/request_key.c
index 0c7aea4dea54..486ef6fa393b 100644
--- a/security/keys/request_key.c
+++ b/security/keys/request_key.c
@@ -414,6 +414,7 @@ link_check_failed:
 
 link_prealloc_failed:
 	mutex_unlock(&user->cons_lock);
+	key_put(key);
 	kleave(" = %d [prelink]", ret);
 	return ret;
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/