linux-kernel - Re: [PATCH] Don't leak a key reference if request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.11.1502161327210.30698@namei.org>
Date:	Mon, 16 Feb 2015 13:27:31 +1100 (AEDT)
From:	James Morris <jmorris@...ei.org>
To:	David Howells <dhowells@...hat.com>
cc:	linux-security-module@...r.kernel.org, keyrings@...ux-nfs.org,
	David Jeffery <djeffery@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Don't leak a key reference if request_key() tries to
 use a revoked keyring

On Thu, 12 Feb 2015, David Howells wrote:

> From: David Jeffery <djeffery@...hat.com>
> 
> If a request_key() call to allocate and fill out a key attempts to insert the
> key structure into a revoked keyring, the key will leak, using memory and part
> of the user's key quota until the system reboots. This is from a failure of
> construct_alloc_key() to decrement the key's reference count after the attempt
> to insert into the requested keyring is rejected.
> 
> key_put() needs to be called in the link_prealloc_failed callpath to ensure
> the unused key is released.
> 
> Signed-off-by: David Jeffery <djeffery@...hat.com>
> Signed-off-by: David Howells <dhowells@...hat.com>

Applied.


-- 
James Morris
<jmorris@...ei.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/