linux-kernel - Re: [PATCH 2/4] spi: imx: checkpatch cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1423763078.15343.32.camel@perches.com>
Date:	Thu, 12 Feb 2015 09:44:38 -0800
From:	Joe Perches <joe@...ches.com>
To:	aurélien bouin <a.bouin@...il.com>
Cc:	broonie <broonie@...nel.org>, Fabio Estevam <festevam@...il.com>,
	linux-spi <linux-spi@...r.kernel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] spi: imx: checkpatch cleanup

On Thu, 2015-02-12 at 14:03 +0100, aurélien bouin wrote:
> Hello,

Rehi

> It does not change readability ... Often breaks are in functions parameters ...

[please don't top post, more below]

> > > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> > []
> > > @@ -282,7 +282,8 @@ static unsigned int mx51_ecspi_clkdiv(unsigned int fin, unsigned int fspi,
[]
> > > -static void __maybe_unused mx51_ecspi_intctrl(struct spi_imx_data *spi_imx, int enable)
> > > +static void __maybe_unused mx51_ecspi_intctrl(struct spi_imx_data *spi_imx,
> > > +             int enable)
> > Perhaps it'd be better to use this style:
> > __maybe_unused
> > static void foo(...)
> > ie:
> > __maybe_unused
> > static void mx51_ecspi_intctrl(struct spi_imx_data *spi_imx, int enable)

It's not the break in the function parameters that
matters much, it's the more difficult mechanism to
find the function itself.

typical is:

[static] [const] <type> <function>(params...)

inserting <attribute> between <type> and <function>
breaks that pattern and can make it harder for
less comprehensive code parsers to identify the
function names.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/