linux-kernel - Re: [PATCH v2 3/3] clk: Replace explicit clk assignment with __clk_hw_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54DDA657.7030407@collabora.co.uk>
Date:	Fri, 13 Feb 2015 08:23:03 +0100
From:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
To:	Stephen Boyd <sboyd@...eaurora.org>,
	Mike Turquette <mturquette@...aro.org>
CC:	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	Emilio López 
	<emilio@...pez.com.ar>,
	Peter De Schrijver <pdeschrijver@...dia.com>,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Giuseppe Cavallaro <peppe.cavallaro@...com>,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] clk: Replace explicit clk assignment with __clk_hw_set_clk

Hello Stephen,

On 02/12/2015 08:55 PM, Stephen Boyd wrote:
> On 02/12/15 05:58, Javier Martinez Canillas wrote:
>>
>> The changes were made using the following cocinelle semantic patch:
>>
>> @i@
>> @@
>>
>> @depends on i@
>> identifier dst;
>> @@
>>
>> - dst->clk = hw->clk;
>> + __clk_hw_set_clk(dst, hw);
>>
>> @depends on i@
>> identifier dst;
>> @@
>>
>> - dst->hw.clk = hw->clk;
>> + __clk_hw_set_clk(&dst->hw, hw);
>>
>> Fixes: 035a61c314eb3 ("clk: Make clk API return per-user struct clk instances")
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>
> 
> Reviewed-by: Stephen Boyd <sboyd@...eaurora.org>
> 

Thanks a lot for your review.

> Did you run this on all files that include clk-provider.h? I hope there
> aren't similar situations in arch/arm/ for example.
> 

Yes, I did run spatch against all the files that include clk-provider.h
but only were matches in the drivers/clk files changed by $subject.

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/