linux-kernel - Re: [PATCH v2 2/3] clk: Add __clk_hw_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54DDA793.9080909@collabora.co.uk>
Date:	Fri, 13 Feb 2015 08:28:19 +0100
From:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
To:	Stephen Boyd <sboyd@...eaurora.org>,
	Mike Turquette <mturquette@...aro.org>
CC:	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	Emilio López 
	<emilio@...pez.com.ar>,
	Peter De Schrijver <pdeschrijver@...dia.com>,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Giuseppe Cavallaro <peppe.cavallaro@...com>,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] clk: Add __clk_hw_set_clk helper function

Hello Stephen,

On 02/12/2015 08:55 PM, Stephen Boyd wrote:
> On 02/12/15 05:58, Javier Martinez Canillas wrote:
>> After the clk API change to return a per-user clock instance, both the
>> struct clk_core and struct clk pointers from the hw clock needs to be
>> assigned to clock that share the same state.
>>
>> In the future the struct clk_core will be removed and this is going to
> 
> s/clk_core/clk/?
>

hrmm, I thought that the plan was to eventually merge clk_core into clk_hw.

In any case, if I got it backwards then I guess that the commit message
could be fixed up by Mike when the patches are applied?

>> change again so to avoid having to change the assignments twice in all
>> the drivers, add a helper function to have an indirection level.
>>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>
>> ---
> 
> Reviewed-by: Stephen Boyd <sboyd@...eaurora.org>
> 

Thanks a lot for your review.

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/