linux-kernel - Re: [PATCHv6 2/2] INPUT: Introduce generic trigger/LED pairs to input LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150217185008.GA21348@xo-6d-61-c0.localdomain>
Date:	Tue, 17 Feb 2015 19:50:08 +0100
From:	Pavel Machek <pavel@....cz>
To:	Samuel Thibault <samuel.thibault@...-lyon.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	David Herrmann <dh.herrmann@...il.com>,
	akpm@...ux-foundation.org, jslaby@...e.cz,
	Bryan Wu <cooloney@...il.com>, rpurdie@...ys.net,
	linux-kernel@...r.kernel.org, Evan Broder <evan@...oder.net>,
	Arnaud Patard <arnaud.patard@...-net.org>,
	Peter Korsgaard <jacmet@...site.dk>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Rob Clark <robdclark@...il.com>,
	Niels de Vos <devos@...oraproject.org>,
	linux-arm-kernel@...ts.infradead.org, blogic@...nwrt.org,
	Pali Roh?r <pali.rohar@...il.com>
Subject: Re: [PATCHv6 2/2] INPUT: Introduce generic trigger/LED pairs to
 input LEDs

Hi!

> This permits to reassign input LEDs to something else than keyboard "leds"
> state, by adding a trigger and a led for each input leds, the former being
> triggered by EV_LED events, and the latter being by default triggered by the
> former. The user can then make the LED use another trigger, including other LED
> triggers of the same keyboard.
> 
> The hardware LEDs are now not actioned from the EV_LED event any more, but from
> the per-device LED layer.

I applied patches on top of 3.20-rc0. Note that capslock LED was broken _before_ this change
on both thinkpad and desktop, and that Numlock on thinkpad did crazy stuff _before_ this 
change, too.

In default configuration, everything works as before. (Good).

echo kbd-numlock > vt::capsl/trigger makes capslock led stay on after cycling the led
(on thinkpad). heartbeat trigger works.

echo heartbeat > input4::capsl/trigger has expected effect.

echo heartbeat > input4::numl/trigger does not seem to have any effect.

Ok, it seems that numlock is just being handled specially on thinkpad (it also means 
uio keys change meaning), I guess that's nothing to worry about.

Tested-by: Pavel Machek <pavel@....cz>

									Pavel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/