linux-kernel - Re: [PATCH] ipc: Remove uses of return value of seq_printf/seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1424214162.25416.9.camel@perches.com>
Date:	Tue, 17 Feb 2015 15:02:42 -0800
From:	Joe Perches <joe@...ches.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ipc: Remove uses of return value of seq_printf/seq_puts

On Tue, 2015-02-17 at 14:52 -0800, Andrew Morton wrote:
> On Tue, 17 Feb 2015 11:44:48 -0800 Joe Perches <joe@...ches.com> wrote:
> 
> > These functions are soon going to return void
> 
> That's news to me.

https://lkml.org/lkml/2014/11/4/393

> > so remove the
> > return value uses.
> > 
> > Convert the return value to test seq_has_overflowed() instead.
> 
> Why not make seq_printf() return seq_has_overflowed()?

Unnecessary overhead.

> I'm sure it's all very sensible, but the changelogging is poor.  Perhaps
> doing all this in a coherent patch series would be a better way.

The changes span too many subsystems.

These could just return 0 for the most part.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/