linux-kernel - [tip:irq/urgent] x86/irq: Fix regression caused by commit b568b8601f05

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-1ea76fbadd667b19c4fa4466f3a3b55a505e83d9@git.kernel.org>
Date:	Wed, 18 Feb 2015 09:08:06 -0800
From:	tip-bot for Jiang Liu <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	syrjala@....fi, tglx@...utronix.de, linux-kernel@...r.kernel.org,
	pavel@....cz, hpa@...or.com, mingo@...nel.org,
	torvalds@...ux-foundation.org, jiang.liu@...ux.intel.com,
	peterz@...radead.org, len.brown@...el.com, rjw@...ysocki.net,
	linux@...elenboom.it
Subject: [tip:irq/urgent] x86/irq:
  Fix regression caused by commit b568b8601f05

Commit-ID:  1ea76fbadd667b19c4fa4466f3a3b55a505e83d9
Gitweb:     http://git.kernel.org/tip/1ea76fbadd667b19c4fa4466f3a3b55a505e83d9
Author:     Jiang Liu <jiang.liu@...ux.intel.com>
AuthorDate: Mon, 16 Feb 2015 10:11:13 +0800
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Wed, 18 Feb 2015 15:01:41 +0100

x86/irq: Fix regression caused by commit b568b8601f05

Commit b568b8601f05 ("Treat SCI interrupt as normal GSI interrupt")
accidently removes support of legacy PIC interrupt when fixing a
regression for Xen, which causes a nasty regression on HP/Compaq
nc6000 where we fail to register the ACPI interrupt, and thus
lose eg. thermal notifications leading a potentially overheated
machine.

So reintroduce support of legacy PIC based ACPI SCI interrupt.

Reported-by: Ville Syrjälä <syrjala@....fi>
Tested-by: Ville Syrjälä <syrjala@....fi>
Signed-off-by: Jiang Liu <jiang.liu@...ux.intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
Acked-by: Pavel Machek <pavel@....cz>
Cc: <stable@...r.kernel.org> # 3.19+
Cc: H. Peter Anvin <hpa@...or.com>
Cc: Len Brown <len.brown@...el.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Rafael J. Wysocki <rjw@...ysocki.net>
Cc: Sander Eikelenboom <linux@...elenboom.it>
Cc: linux-pm@...r.kernel.org
Link: http://lkml.kernel.org/r/1424052673-22974-1-git-send-email-jiang.liu@linux.intel.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/kernel/acpi/boot.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index a18fff3..8b59163 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -613,6 +613,11 @@ int acpi_gsi_to_irq(u32 gsi, unsigned int *irqp)
 {
 	int rc, irq, trigger, polarity;
 
+	if (acpi_irq_model == ACPI_IRQ_MODEL_PIC) {
+		*irqp = gsi;
+		return 0;
+	}
+
 	rc = acpi_get_override_irq(gsi, &trigger, &polarity);
 	if (rc == 0) {
 		trigger = trigger ? ACPI_LEVEL_SENSITIVE : ACPI_EDGE_SENSITIVE;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/