linux-kernel - Re: drm: bridge: ps8622 and ptn3460 depend on gpiolib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54E4EE06.8050101@collabora.co.uk>
Date:	Wed, 18 Feb 2015 20:54:46 +0100
From:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
To:	Arnd Bergmann <arnd@...db.de>, David Airlie <airlied@...ux.ie>
CC:	dri-devel@...ts.freedesktop.org,
	Vincent Palatin <vpalatin@...omium.org>,
	Andrew Bresticker <abrestic@...omium.org>,
	Sean Paul <seanpaul@...omium.org>,
	Rahul Sharma <rahul.sharma@...sung.com>,
	Ajay Kumar <ajaykumar.rs@...sung.com>,
	Thierry Reding <treding@...dia.com>,
	Inki Dae <inki.dae@...sung.com>,
	Sjoerd Simons <sjoerd.simons@...labora.co.uk>,
	Gustavo Padovan <gustavo.padovan@...labora.co.uk>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: drm: bridge: ps8622 and ptn3460 depend on gpiolib

Hello Arnd,

On 02/18/2015 05:09 PM, Arnd Bergmann wrote:
> The ptn3460 driver recently started usign the gpiod interface
> which is only available on platforms that come with GPIOLIB
> support, resulting in a compile-time error:
> 
> drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_pre_enable':
> drivers/gpu/drm/bridge/ps8622.c:368:2: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
>   gpiod_set_value(ps8622->gpio_rst, 0);
>   ^
> drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_probe':
> drivers/gpu/drm/bridge/ps8622.c:584:2: error: implicit declaration of function 'devm_gpiod_get' [-Werror=implicit-function-declaration]
>   ps8622->gpio_slp = devm_gpiod_get(dev, "sleep");
>   ^
> 
> Similarly, the newly added ps8622 driver started out with the same
> problem.
> 
> This patch adds explicit Kconfig dependencies to avoid trying to
> build invalid configurations.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: f1336e6afb ("drm/bridge: Add I2C based driver for ps8622/ps8625 bridge")
> Fixes: af478d8823 ("drm/bridge: ptn3460: use gpiod interface")
>

Patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/