linux-kernel - Re: drm: bridge: ps8622 and ptn3460 depend on gpiolib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150219093233.GF5086@ulmo.nvidia.com>
Date:	Thu, 19 Feb 2015 10:32:34 +0100
From:	Thierry Reding <treding@...dia.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	David Airlie <airlied@...ux.ie>, <dri-devel@...ts.freedesktop.org>,
	Vincent Palatin <vpalatin@...omium.org>,
	Andrew Bresticker <abrestic@...omium.org>,
	Sean Paul <seanpaul@...omium.org>,
	Rahul Sharma <rahul.sharma@...sung.com>,
	Ajay Kumar <ajaykumar.rs@...sung.com>,
	"Javier Martinez Canillas" <javier.martinez@...labora.co.uk>,
	Inki Dae <inki.dae@...sung.com>,
	Sjoerd Simons <sjoerd.simons@...labora.co.uk>,
	Gustavo Padovan <gustavo.padovan@...labora.co.uk>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: drm: bridge: ps8622 and ptn3460 depend on gpiolib

On Wed, Feb 18, 2015 at 05:09:25PM +0100, Arnd Bergmann wrote:
> The ptn3460 driver recently started usign the gpiod interface
> which is only available on platforms that come with GPIOLIB
> support, resulting in a compile-time error:
> 
> drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_pre_enable':
> drivers/gpu/drm/bridge/ps8622.c:368:2: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
>   gpiod_set_value(ps8622->gpio_rst, 0);
>   ^
> drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_probe':
> drivers/gpu/drm/bridge/ps8622.c:584:2: error: implicit declaration of function 'devm_gpiod_get' [-Werror=implicit-function-declaration]
>   ps8622->gpio_slp = devm_gpiod_get(dev, "sleep");
>   ^
> 
> Similarly, the newly added ps8622 driver started out with the same
> problem.
> 
> This patch adds explicit Kconfig dependencies to avoid trying to
> build invalid configurations.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: f1336e6afb ("drm/bridge: Add I2C based driver for ps8622/ps8625 bridge")
> Fixes: af478d8823 ("drm/bridge: ptn3460: use gpiod interface")

Applied, thanks.

Thierry

Content of type "application/pgp-signature" skipped