linux-kernel - Re: Logitech G-series drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150219104827.7f5d4e38@pluto.restena.lu>
Date:	Thu, 19 Feb 2015 10:48:27 +0100
From:	Bruno Prémont <bonbons@...ux-vserver.org>
To:	Ciprian Ciubotariu <cheepeero@....net>
Cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	Jiri Kosina <jkosina@...e.cz>
Subject: Re: Logitech G-series drivers

Hi Ciprian,

Adding linux-input and Jiri (HID maintainer) to CC.

On Sun, 15 Feb 2015 23:17:27 +0200 Ciprian Ciubotariu wrote:
> I would like to submit to your attention for inclusion in the mainline kernel 
> a series of drivers for a set of Logitech keybord devices. I forked the 
> sources under a GPL/GPLv2 license and performed maintenance and stabilization 
> work on them.
> 
> The repository I am working on is at 
> 
>     https://github.com/CMoH/lg4l
> 
> Short description of the modules and files:
> 
>     - hid-g110 - Logitech G110 (tested)
>     - hid-g13 - Logitech G13 (tested)
>     - hid-g15v2 - Logitech G15, version 2 (tested)
>     - hid-g19 - Logitech G19 (tested)
> 
>     - hid-g15 - Logitech G15 (not tested)
>     - hid-g510 - Logitech G510 - not ready
> 
>     - hid-gcore - common functions for other modules
>     - hid-gfb - framebuffer implementation for on-device displays
>     - hid-ids.h - product IDs 
> 
> I would like the opinion of a kernel developer on the possibility of including 
> these drivers in the kernel. If the answer is favorable, I will prepare a 
> series of patches against the kernel's master branch and work towards them 
> being accepted.

>From a quick look at your github tree the drivers are prepared for
building out-of-tree.

Did you check for older work on Logitech keyboards that has been
proposed on linux-input list some time ago and what is currently
present in Linus' tree?

An overview of the features covered by the drivers would help
understand what the new drivers add (and the differences between all
the covered keyboard variants).
There seem to be individual drivers for each keyboard type.
Are the features so different that distinct drivers are needed or can
the drivers be unified?

If you would like to get the drivers merged please create patches
against upstream tree, eventually starting with support for the
keyboard you own, adding support for the other keyboards in separate
patches.
You could also split your patch based on feature support.

It might be worth exploring the option to organize the driver(s) as a
MFD (multi-function-device) device.

Bruno
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/