linux-kernel - Re: [PATCH] ipmi: Remove uses of return value of seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1424304173.25416.28.camel@perches.com>
Date:	Wed, 18 Feb 2015 16:02:53 -0800
From:	Joe Perches <joe@...ches.com>
To:	minyard@....org
Cc:	openipmi-developer@...ts.sourceforge.net,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ipmi: Remove uses of return value of seq_printf

On Wed, 2015-02-18 at 11:56 -0600, Corey Minyard wrote:
> Thanks, queued for 3.20.

Hey Corey, thanks, but I'll either have to send a new
patch or an updated patch changing these new
seq_has_overflowed() uses to 0.

There's no functional difference, but there is a logical
one.  has_overflowed(), if it returns "true" (it won't here
because the first alloc seq_fs does has sufficient space)
would not retry and simply not emit anything.

Anyway, do you want a new patch or a relative patch?

sorry 'bout that,  Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/