linux-kernel - Re: [PATCH] video: ARM CLCD: Add missing error check for devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54E7249C.8050006@ti.com>
Date:	Fri, 20 Feb 2015 14:12:12 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Kiran Padwal <kiran.padwal@...rtplayin.com>
CC:	Russell King <linux@....linux.org.uk>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	<linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Kiran Padwal <kiran.padwal21@...il.com>
Subject: Re: [PATCH] video: ARM CLCD: Add missing error check for devm_kzalloc

On 11/02/15 11:36, Kiran Padwal wrote:
> This patch add a missing check on the return value of devm_kzalloc,
> which would cause a NULL pointer dereference in a OOM situation.
> 
> Signed-off-by: Kiran Padwal <kiran.padwal@...rtplayin.com>
> ---
>  drivers/video/fbdev/amba-clcd.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c
> index 32c0b6b..9362424 100644
> --- a/drivers/video/fbdev/amba-clcd.c
> +++ b/drivers/video/fbdev/amba-clcd.c
> @@ -599,6 +599,9 @@ static int clcdfb_of_get_mode(struct device *dev, struct device_node *endpoint,
>  
>  	len = clcdfb_snprintf_mode(NULL, 0, mode);
>  	name = devm_kzalloc(dev, len + 1, GFP_KERNEL);
> +	if (!name)
> +		return -ENOMEM;
> +
>  	clcdfb_snprintf_mode(name, len + 1, mode);
>  	mode->name = name;
>  
> 

Thanks, queued for 3.20.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)