linux-kernel - Re: [PATCH] video: fbdev: fix possible null dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54E724F9.9010404@ti.com>
Date:	Fri, 20 Feb 2015 14:13:45 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
CC:	<linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] video: fbdev: fix possible null dereference

On 12/02/15 17:47, Sudip Mukherjee wrote:
> we were dereferencing edid first and the NULL check was after
> accessing that. now we are using edid only if we know that
> it is not NULL.
> 
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> ---
>  drivers/video/fbdev/core/fbmon.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c
> index 9533859..868facd 100644
> --- a/drivers/video/fbdev/core/fbmon.c
> +++ b/drivers/video/fbdev/core/fbmon.c
> @@ -624,9 +624,6 @@ static struct fb_videomode *fb_create_modedb(unsigned char *edid, int *dbsize,
>  	int num = 0, i, first = 1;
>  	int ver, rev;
>  
> -	ver = edid[EDID_STRUCT_VERSION];
> -	rev = edid[EDID_STRUCT_REVISION];
> -
>  	mode = kzalloc(50 * sizeof(struct fb_videomode), GFP_KERNEL);
>  	if (mode == NULL)
>  		return NULL;
> @@ -637,6 +634,9 @@ static struct fb_videomode *fb_create_modedb(unsigned char *edid, int *dbsize,
>  		return NULL;
>  	}
>  
> +	ver = edid[EDID_STRUCT_VERSION];
> +	rev = edid[EDID_STRUCT_REVISION];
> +
>  	*dbsize = 0;
>  
>  	DPRINTK("   Detailed Timings\n");
> 

Thanks, queued for 3.20.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)