[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150220131336.GA22731@kt-Inspiron-3542>
Date: Fri, 20 Feb 2015 18:43:53 +0530
From: Tapasweni Pathak <tapaswenipathak@...il.com>
To: gregkh@...uxfoundation.org, vinc94@...il.com,
roberta.dobrescu@...il.com, sachin.kamat@...sung.com,
ebru.akagunduz@...il.com, damm+renesas@...nsource.se,
chris@...vick.com, devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Cc: tapaswenipathak@...il.com, julia.lawall@...6.fr
Subject: [PATCH] staging: emxx_udc: Replace GFP_KERNEL with GFP_ATOMIC
To avoid deadlock, do not call blocking functions with spinlocks held.
Replace GFP_KERNEL with GFP_ATOMIC, as the latter will fail if the pile
doesn't have enough free pages but will not sleep and hence deadlock can
be avoided.
Found by Coccinelle.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@...il.com>
---
Is there any other way this can be fixed as it is better to avoid GFP_ATOMIC?
drivers/staging/emxx_udc/emxx_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
index 4be646c..6c1de27 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -2794,7 +2794,7 @@ static int nbu2ss_ep_queue(
if (ep->virt_buf == NULL)
ep->virt_buf = (u8 *)dma_alloc_coherent(
NULL, PAGE_SIZE,
- &ep->phys_buf, GFP_KERNEL | GFP_DMA);
+ &ep->phys_buf, GFP_ATOMIC | GFP_DMA);
if (ep->epnum > 0) {
if (ep->direct == USB_DIR_IN)
memcpy(ep->virt_buf, req->req.buf,
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists