linux-kernel - Re: [PATCH] staging: emxx_udc: Replace GFP_KERNEL with GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150224232500.GA24927@kroah.com>
Date:	Tue, 24 Feb 2015 15:25:00 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Tapasweni Pathak <tapaswenipathak@...il.com>
Cc:	vinc94@...il.com, roberta.dobrescu@...il.com,
	sachin.kamat@...sung.com, ebru.akagunduz@...il.com,
	damm+renesas@...nsource.se, chris@...vick.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	julia.lawall@...6.fr
Subject: Re: [PATCH] staging: emxx_udc: Replace GFP_KERNEL with GFP_ATOMIC

On Fri, Feb 20, 2015 at 06:43:53PM +0530, Tapasweni Pathak wrote:
> To avoid deadlock, do not call blocking functions with spinlocks held.
> 
> Replace GFP_KERNEL with GFP_ATOMIC, as the latter will fail if the pile
> doesn't have enough free pages but will not sleep and hence deadlock can
> be avoided.
> 
> Found by Coccinelle.
> 
> Signed-off-by: Tapasweni Pathak <tapaswenipathak@...il.com>
> ---
> Is there any other way this can be fixed as it is better to avoid GFP_ATOMIC?

No, this is fine, nice fix.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/