linux-kernel - Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150220163209.4e082e0b@bee>
Date:	Fri, 20 Feb 2015 16:32:09 +0100
From:	Michael Mueller <mimu@...ux.vnet.ibm.com>
To:	Alexander Graf <agraf@...e.de>
Cc:	qemu-devel@...gnu.org, kvm@...r.kernel.org,
	linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
	Gleb Natapov <gleb@...nel.org>,
	Christian Borntraeger <borntraeger@...ibm.com>,
	"Jason J. Herne" <jjherne@...ux.vnet.ibm.com>,
	Cornelia Huck <cornelia.huck@...ibm.com>,
	Paolo Bonzini <pbonzini@...hat.com>,
	Andreas Faerber <afaerber@...e.de>,
	Richard Henderson <rth@...ddle.net>
Subject: Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor
 property routines

On Fri, 20 Feb 2015 15:03:30 +0100
Alexander Graf <agraf@...e.de> wrote:

> > 
> > - s390_get_proceccor_props()
> > - s390_set_proceccor_props()
> > 
> > They can be used to request or retrieve processor related information from an accelerator.
> > That information comprises the cpu identifier, the ICB value and the facility lists.
> > 
> > Signed-off-by: Michael Mueller <mimu@...ux.vnet.ibm.com>  
> 
> Hrm, I still seem to miss the point of this interface. What do you need
> it for?

These functions make the internal s390 cpu model API independent from a specific accelerator:  

int s390_set_processor_props(S390ProcessorProps *prop)
{
    if (kvm_enabled()) {
        return kvm_s390_set_processor_props(prop);
    }
    return -ENOSYS;
}

It's called by:

s390_select_cpu_model(const char *model)

which is itself called by:

S390CPU *cpu_s390x_init(const char *cpu_model)
{
    S390CPU *cpu;

    cpu = S390_CPU(object_new(s390_select_cpu_model(cpu_model)));

    object_property_set_bool(OBJECT(cpu), true, "realized", NULL);

    return cpu;
}

So above s390_set/get_processor_props() the code is accelerator independent.

Michael





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/