linux-kernel - Re: [PATCH 3/7] thinkpad_acpi: Add adaptive_kbd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1424446307.22910.24.camel@hadess.net>
Date:	Fri, 20 Feb 2015 16:31:47 +0100
From:	Bastien Nocera <hadess@...ess.net>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:	Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
	Darren Hart <dvhart@...radead.org>,
	ibm-acpi-devel@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org, Jiri Kosina <jkosina@...e.cz>
Subject: Re: [PATCH 3/7] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr

On Fri, 2015-02-20 at 17:27 +0200, Mika Westerberg wrote:
> On Fri, Feb 20, 2015 at 04:22:07PM +0100, Bastien Nocera wrote:
> > On Fri, 2015-02-20 at 17:20 +0200, Mika Westerberg wrote:
> > > On Fri, Feb 20, 2015 at 03:44:22PM +0100, Bastien Nocera wrote:
> > > > Add a sysfs attribute to allow privileged users to change the keyboard
> > > > mode. This could be used by desktop environments to change the keyboard
> > > > mode depending on the application focused, as the Windows application
> > > > does.
> > > 
> > > If you are adding new sysfs attributes, you should document them as well
> > > in Documentation/ABI/*.
> > 
> > None of the thinkpad_acpi sysfs attributes are documented there, or I'm
> > missing something obvious.
> 
> Perhaps it is good time to start documenting them? :-)

I'm not going to do that. If I were, I would remove a large majority of
them to cut down on the size of the driver. 10k lines of code and
supporting 10+ years of ThinkPads turned the driver into a monster.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/