linux-kernel - Re: [PATCH 6/7 linux-next] wan: cosa: replace current->state by set_current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54E77E34.6050909@cogentembedded.com>
Date:	Fri, 20 Feb 2015 21:34:28 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Fabian Frederick <fabf@...net.be>, linux-kernel@...r.kernel.org
CC:	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Jan \"Yenya\" Kasprzak" <kas@...muni.cz>, netdev@...r.kernel.org
Subject: Re: [PATCH 6/7 linux-next] wan: cosa: replace current->state by set_current_state()

Hello.

On 02/20/2015 09:12 PM, Fabian Frederick wrote:

> Use helper functions to access current->state.
> Direct assignments are prone to races and therefore buggy.

> current->state = TASK_RUNNING is replaced by __set_current_state()

    You sometimes use __set_current_state() and sometimes set_current_state().

> Thanks to Peter Zijlstra for the exact definition of the problem.

> Suggested-By: Peter Zijlstra <peterz@...radead.org>
> Signed-off-by: Fabian Frederick <fabf@...net.be>

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/