linux-kernel - Re: [PATCH 1/1] nilfs2: fix potential memory overrun on inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150220180055.443bbce8.akpm@linux-foundation.org>
Date:	Fri, 20 Feb 2015 18:00:55 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>
Cc:	linux-kernel@...r.kernel.org, linux-nilfs@...r.kernel.org,
	Richard Henderson <rth@...ddle.net>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	Matt Turner <mattst88@...il.com>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>
Subject: Re: [PATCH 1/1] nilfs2: fix potential memory overrun on inode

On Sat, 21 Feb 2015 10:13:28 +0900 (JST) Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp> wrote:

> I've got a warning from 0day kernel testing backend:
> 
>     fs/nilfs2/btree.c: In function 'nilfs_btree_root_broken':
> >> fs/nilfs2/btree.c:394:3: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'ino_t' [-Wformat=]
>        pr_crit("NILFS: bad btree root (inode number=%lu): level = %d, 
> flags = 0x%x, nchildren = %d\n",
>        ^
> 
> This is output for s390 arch since ino_t doesn't mean "unsigned long"
> in s390.

alpha uses uint for ino_t as well.

It seems a bit pointless - neither arch uses ino_t in ./arch/ code.  I
suspect both could switch to ulong, which would make the world a
slightly better place.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/