linux-kernel - Re: [PATCH v2 3/4] scsi: ufs: add trace events and dump prints for debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7bcf021bd1c2cfe9ca02669bf11f5f5.squirrel@codeaurora.org>
Date:	Sun, 22 Feb 2015 14:58:34 -0000
From:	"Gilad Broner" <gbroner@...eaurora.org>
To:	"Steven Rostedt" <rostedt@...dmis.org>
Cc:	"Gilad Broner" <gbroner@...eaurora.org>,
	james.bottomley@...senpartnership.com,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, santoshsy@...il.com,
	linux-scsi-owner@...r.kernel.org, subhashj@...eaurora.org,
	ygardi@...eaurora.org, draviv@...eaurora.org,
	"Lee Susman" <lsusman@...eaurora.org>,
	"Sujit Reddy Thumma" <sthumma@...eaurora.org>,
	"Vinayak Holikatti" <vinholikatti@...il.com>,
	"James E.J. Bottomley" <jbottomley@...allels.com>,
	"Ingo Molnar" <mingo@...hat.com>
Subject: Re: [PATCH v2 3/4] scsi: ufs: add trace events and dump prints for
 debug

>>  struct ufs_stats {
>> +#ifdef CONFIG_DEBUG_FS
>>  	bool enabled;
>>  	u64 **tag_stats;
>>  	int q_depth;
>>  	int err_stats[UFS_ERR_MAX];
>> +#endif
>
> Can any of the tracepoint code be called that references these when
> CONFIG_DEBUG_FS is not set? Because soon (possibly even this merge
> window), tracing will no longer depend on DEBUG_FS, because it will
> have its own filesystem.

Thanks for the update about this dependency.
None of these are used for the tracepoints, so I don't expect any problems.

Gilad.

-- 
Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/