linux-kernel - Re: [PATCH v2 2/4] scsi: ufs: add debugfs for ufs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bfd83fb637774cb3f732f926423f8b2b.squirrel@codeaurora.org>
Date:	Sun, 22 Feb 2015 15:00:21 -0000
From:	"Gilad Broner" <gbroner@...eaurora.org>
To:	"Akinobu Mita" <akinobu.mita@...il.com>
Cc:	"Gilad Broner" <gbroner@...eaurora.org>,
	"Jej B" <james.bottomley@...senpartnership.com>,
	"LKML" <linux-kernel@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	linux-arm-msm@...r.kernel.org, "Santosh Y" <santoshsy@...il.com>,
	linux-scsi-owner@...r.kernel.org,
	"Subhash Jadavani" <subhashj@...eaurora.org>,
	"Yaniv Gardi" <ygardi@...eaurora.org>,
	"Dolev Raviv" <draviv@...eaurora.org>,
	"Lee Susman" <lsusman@...eaurora.org>,
	"Raviv Shvili" <rshvili@...eaurora.org>,
	"Vinayak Holikatti" <vinholikatti@...il.com>,
	"James E.J. Bottomley" <jbottomley@...allels.com>
Subject: Re: [PATCH v2 2/4] scsi: ufs: add debugfs for ufs

> UFSDBG_REMOVE_DEBUGFS() is not called in the driver unloading path.
> So ufs debugfs directory is not removed when unloading driver.  It
> should be called in ufshcd_remove().
>
> BTW, do we really need UFSDBG_ADD_DEBUGFS() and UFSDBG_REMOVE_DEBUGFS()
> macros?
> We can use static inline functions in ufs-debugfs.h when !CONFIG_DEBUG_FS.
>
> #ifdef CONFIG_DEBUG_FS
> void ufsdbg_add_debugfs(struct ufs_hba *hba);
>
> void ufsdbg_remove_debugfs(struct ufs_hba *hba);
> #else
> static inline void ufsdbg_add_debugfs(struct ufs_hba *hba)
> {
> }
>
> static inline void ufsdbg_remove_debugfs(struct ufs_hba *hba)
> {
> }
> #endif
>

Thanks, I will fix the above two points and upload another patch.

Gilad.

-- 
Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/