linux-kernel - Re: [PATCH 7/7] thinkpad_acpi: use DEVICE_ATTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1424687122.3034736.231116061.6D0FF46D@webmail.messagingengine.com>
Date:	Mon, 23 Feb 2015 07:25:22 -0300
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	Bastien Nocera <hadess@...ess.net>,
	Darren Hart <dvhart@...radead.org>,
	ibm-acpi-devel@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org, Jiri Kosina <jkosina@...e.cz>
Subject: Re: [PATCH 7/7] thinkpad_acpi: use DEVICE_ATTR_* macros

On Fri, Feb 20, 2015, at 11:44, Bastien Nocera wrote:
> Use the DEVICE_ATTR_RW macro to reduce boiler plate

So far, so good, but you also used the DEVICE_ATTR_RO macro...

> and move the attribute declaration to get rid of function signatures.

I didn't see any "move the attribute declaration" done in this patch.

Other than that, looks good.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/