[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150223102526.GB14142@griffinp-ThinkPad-X1-Carbon-2nd>
Date: Mon, 23 Feb 2015 10:25:26 +0000
From: Peter Griffin <peter.griffin@...aro.org>
To: Lee Jones <lee.jones@...aro.org>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, kernel@...inux.com,
rtc-linux@...glegroups.com, wim@...ana.be, linux@...ck-us.net,
linux-watchdog@...r.kernel.org
Subject: Re: [STLinux Kernel] [PATCH v3 5/8] watchdog: st_wdt: Add new driver
for ST's LPC Watchdog
Hi Lee,
<snip>
> +#ifdef CONFIG_PM_SLEEP
> +static int st_wdog_suspend(struct device *dev)
> +{
> + struct st_wdog *st_wdog = watchdog_get_drvdata(&st_wdog_dev);
> +
> + if (watchdog_active(&st_wdog_dev))
> + st_wdog_stop(&st_wdog_dev);
> +
> + st_wdog_setup(st_wdog, false);
I was expecting the suspend / resume callbacks would be disabling / enabling
the IP clock.
Is there a reason why it doesn't?
>From looking at the code by this point the watchdog has already been disabled so gating
the IP seems reasonable.
regards,
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists