linux-kernel - Re: [PATCH] perf/x86: Remove redundant calls to perf_pmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150223170902.GD5029@twins.programming.kicks-ass.net>
Date:	Mon, 23 Feb 2015 18:09:02 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	David Ahern <dsahern@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf/x86: Remove redundant calls to perf_pmu_{dis|en}able

On Mon, Feb 23, 2015 at 09:49:35AM -0700, David Ahern wrote:
> Hi Peter:
> 
> On 2/18/15 10:45 AM, David Ahern wrote:
> >perf_pmu_disable is called before pmu->add and perf_pmu_enable is called
> >afterwards. No need to call these inside of x86_pmu_add as well.
> 
> Does this make sense or did I miss something about the pmu_enable/disable
> functions?

No, I think you're right. Applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/