linux-kernel - Re: [PATCH] tools lib traceevent: Use realpath for srctree and objtree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150223210932.10d2338b@grimm.local.home>
Date:	Mon, 23 Feb 2015 21:09:32 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Wang Nan <wangnan0@...wei.com>
Cc:	<linux-kernel@...r.kernel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Jiri Olsa <jolsa@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Geng Hui <hui.geng@...wei.com>
Subject: Re: [PATCH] tools lib traceevent: Use realpath for srctree and
 objtree

Another email inbox clean up: BLAST FROM THE PAST

On Fri, 7 Feb 2014 12:22:33 +0800
Wang Nan <wangnan0@...wei.com> wrote:

> If BUILD_SRC or CURDIR contains tailing '/', the file names passed to gcc will
> contain '//'. It will be contained .o's in debuginfo, then confuse debugedit:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=304121
> 
> This patch uses realpath command to makesure potential tailing '/'s are removed.

Is this still an issue? I know Jiri did a bunch of changes to the make
process, but does this still confuse debugedit (whatever that is)?

-- Steve

> 
> Signed-off-by: Wang Nan <wangnan0@...wei.com>
> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> Cc: Jiri Olsa <jolsa@...hat.com>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Geng Hui <hui.geng@...wei.com>
> 
> ---
>  tools/lib/traceevent/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
> index 005c9cc..5bb281c 100644
> --- a/tools/lib/traceevent/Makefile
> +++ b/tools/lib/traceevent/Makefile
> @@ -107,8 +107,8 @@ endif # BUILD_SRC
>  # We process the rest of the Makefile if this is the final invocation of make
>  ifeq ($(skip-makefile),)
>  
> -srctree		:= $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR))
> -objtree		:= $(CURDIR)
> +srctree		:= $(realpath $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR)))
> +objtree		:= $(realpath $(CURDIR))
>  src		:= $(srctree)
>  obj		:= $(objtree)
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/