linux-kernel - Re: [PATCH] i2c: i2c-bcm2835: match return type of wait_for_completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150225144824.GA5132@x1>
Date:	Wed, 25 Feb 2015 14:48:24 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Nicholas Mc Guire <hofrat@...dl.org>
Cc:	Wolfram Sang <wsa@...-dreams.de>,
	Stephen Warren <swarren@...dotorg.org>,
	Lee Jones <lee@...nel.org>, Jingoo Han <jg1.han@...sung.com>,
	Felipe Balbi <balbi@...com>,
	Uwe Kleine-Koenig <u.kleine-koenig@...gutronix.de>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	linux-i2c@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: i2c-bcm2835: match return type of
 wait_for_completion_timeout

On Sun, 08 Feb 2015, Nicholas Mc Guire wrote:

> return type of wait_for_completion_timeout is unsigned long not int. as
> time_left is used for wait_for_completion_timeout exclusively here its 
> type is simply changed to unsigned long.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
> ---
> 
> Patch was only compile tested with 
> 
> Patch is against 3.19.0-rc7 (localversion-next is -next-20150204)
> 
>  drivers/i2c/busses/i2c-bcm2835.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Lee Jones <lee.jones@...aro.org>

> diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
> index 5d6feb9..c9336a3 100644
> --- a/drivers/i2c/busses/i2c-bcm2835.c
> +++ b/drivers/i2c/busses/i2c-bcm2835.c
> @@ -147,7 +147,7 @@ static int bcm2835_i2c_xfer_msg(struct bcm2835_i2c_dev *i2c_dev,
>  				struct i2c_msg *msg)
>  {
>  	u32 c;
> -	int time_left;
> +	unsigned long time_left;
>  
>  	i2c_dev->msg_buf = msg->buf;
>  	i2c_dev->msg_buf_remaining = msg->len;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/