linux-kernel - Re: [PATCH 1/1] serial: 8250_dw: Fix get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54EE29CF.6090208@broadcom.com>
Date:	Wed, 25 Feb 2015 12:00:15 -0800
From:	Jonathan Richardson <jonathar@...adcom.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	Dmitry Torokhov <dtor@...gle.com>,
	Anatol Pomazau <anatol@...gle.com>,
	Scott Branden <sbranden@...adcom.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	"Ian Campbell" <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-serial@...r.kernel.org>
Subject: Re: [PATCH 1/1] serial: 8250_dw: Fix get_mctrl behaviour

Hi Arnd,

On 15-02-25 11:21 AM, Arnd Bergmann wrote:
> On Wednesday 25 February 2015 11:04:16 Jonathan Richardson wrote:
>> +- msr-override : array of strings to be used to override the individual
>> +  modem status signals for DCD, DSR, CTS, and RI.  If the property is not
>> +  present, the individual signals are obtained from the modem status register.
>> +  Strings accepted are "dcd", "dsr", "cts", and "ri". If "dcd", "dsr", or
>> +  "cts" are present, these signals will always be reported as active. If
>> +  "ri" is present, this signal will always be reported as inactive.
>>
> 
> Did you copy this definition from another driver? If not, we should try
> to come up with a more natural way to do it. How about defining four
> boolean properties instead, like
> 
> 	dcd-override
> 	dsr-override
> 	cts-override
> 	ri-override
> 
> Simplifies the parser and the binding.

I didn't see anything similar in another driver. I agree with the bools
instead of strings. Did you want to keep these in the Synopsis driver
for now or were you thinking of putting them somewhere that they could
be re-used?

Thanks.

> 
> 	Arnd
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/