linux-kernel - Re: [RFC] New of_io_release_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMB+bfKOX5y5hgGwDzg+=SfYO+MRgr815J-teV=xxAR8uS4TFQ@mail.gmail.com>
Date:	Wed, 25 Feb 2015 12:00:45 -0800
From:	Joshua Clayton <stillcompiling@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC] New of_io_release_and_unmap()

On Wed, Feb 25, 2015 at 11:23 AM, Arnd Bergmann <arnd@...db.de> wrote:
> On Wednesday 25 February 2015 11:20:41 Joshua Clayton wrote:
>> Hello folks,
>> I notice that io_request_and_map has no inverse.
>> I would like to add a new function to undo what it does.
>>
>
> What do you want to use this for? So far all users are in essential drivers
> (clk and clocksource) that result in a boot failure if this goes wrong.
>
That explains a lot. It looks (to my n00b eye) like this function leaks some
references, which is more ok if  the ref counters should never be
decremented to 0.

> Normal drivers can probably always use devm_ioremap_resource(), which
> has an automatic cleanup.
>
Hmmm.
My use case is indeed a normal driver, which could definitely
use devm_ioremap_resource()

>         Arnd

That would leave only "completeness" as a reason. Probably not needed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/