linux-kernel - Re: [RFT RESEND 1/4] power_supply: twl4030_madc: Check return value of power_supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150225212227.GI13695@earth>
Date:	Wed, 25 Feb 2015 22:22:27 +0100
From:	Sebastian Reichel <sre@...nel.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Milo Kim <milo.kim@...com>, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, Dmitry Artamonow <mad_soft@...ox.ru>,
	Marek Belisko <marek@...delico.com>, stable@...r.kernel.org
Subject: Re: [RFT RESEND 1/4] power_supply: twl4030_madc: Check return value
 of power_supply_register

Hi Krzysztof,

On Fri, Feb 20, 2015 at 02:32:22PM +0100, Krzysztof Kozlowski wrote:
> The return value of power_supply_register() call was not checked and
> even on error probe() function returned 0. If registering failed then
> during unbind the driver tried to unregister power supply which was not
> actually registered.
> 
> This could lead to memory corruption because power_supply_unregister()
> unconditionally cleans up given power supply.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Fixes: da0a00ebc239 ("power: Add twl4030_madc battery driver.")
> Cc: <stable@...r.kernel.org>

Thanks, added patches 1-4 to fixes branch.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)