linux-kernel - Re: [PATCH 1/4] HID: uclogic: Set quirks from inside the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150225212334.GB3097@mail.corp.redhat.com>
Date:	Wed, 25 Feb 2015 16:23:34 -0500
From:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:	Nikolai Kondrashov <spbnick@...il.com>
Cc:	Jiri Kosina <jkosina@...e.cz>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	DIGImend-devel <DIGImend-devel@...ts.sourceforge.net>
Subject: Re: [PATCH 1/4] HID: uclogic: Set quirks from inside the driver

On Feb 25 2015 or thereabouts, Nikolai Kondrashov wrote:
> On 02/25/2015 02:05 AM, Benjamin Tissoires wrote:
> >Based on a patch from: Nikolai Kondrashov <Nikolai.Kondrashov@...hat.com>
> >
> >Most of the tablets handled by hid-uclogic already uses MULTI_INPUT.
> 
> *use
> 
> >Fot the ones which are not quirked in usbhid/hidquirks, they have a
> 
> *For
> 
> >custom report descriptor which contains only one report per HID
> >interface. For those tablets HID_QUIRK_MULTI_INPUT is transparent.
> >
> >According to https://github.com/DIGImend/tablets, the only problematic
> >tablet currently handled by hid-uclogic is the TWHA60 v3. This tablet
> >presents different report descriptors from the ones currently quirked.
> >This is not a problem per se, given that this tablet is not supported
> >currently in this version (it needs the same command than a Huion to
> 
> *as a Huion
> 
> >start forwarding events).
> 
> Thanks, Benjamin. this will make further merges easier.
> Regardless of the Grammar Nazi comments above (fixing is up to you):

Looks like I will have to send a v2 to fix the 3/4, so I will amend it.

> 
> Reviewed-by: Nikolai Kondrashov <spbnick@...il.com>

Thanks! Appreciated.

Cheers,
Benjamin


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/