linux-kernel - Re: [PATCH] usb: musb: fix Kconfig regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150227202159.GC22641@saruman.tx.rr.com>
Date:	Fri, 27 Feb 2015 14:21:59 -0600
From:	Felipe Balbi <balbi@...com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	<linux-arm-kernel@...ts.infradead.org>,
	Tony Lindgren <tony@...mide.com>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	<ivo.g.dimitrov.75@...il.com>, <khilman@...nel.org>,
	<sre@...ian.org>, kernel list <linux-kernel@...r.kernel.org>,
	<sre@...g0.de>, Sakari Ailus <sakari.ailus@....fi>,
	Pavel Machek <pavel@....cz>, <pali.rohar@...il.com>,
	<linux-omap@...r.kernel.org>, <patrikbachan@...il.com>
Subject: Re: [PATCH] usb: musb: fix Kconfig regression

On Fri, Feb 27, 2015 at 09:12:45PM +0100, Arnd Bergmann wrote:
> A recent bug fix I did that was marked for stable backports
> introduced a slightly wrong dependency on CONFIG_OMAP_CONTROL_PHY.
> 
> I was missing the fact that the PHY driver already stubs out the
> omap_control_usb_set_mode, and we only need to add a dependency
> to prevent the musb-omap2430 driver from being built-in when
> the phy driver is a loadable module, but we should not prevent it
> from being built altogether when the phy driver is disabled.
> 
> This changes the dependency to allow OMAP_CONTROL_PHY to
> be disabled, but to disallow USB_MUSB_OMAP2PLUS from being
> built-in if OMAP_CONTROL_PHY is a loadable module.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: ca784be36cc725 ("usb: start using the control module driver")
> Cc: <stable@...r.kernel.org> # v3.9+
> Cc: Felipe Balbi <balbi@...com>

please resend with linux-usb in Cc and myself in Cc too ;-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)