linux-kernel - Re: [PATCH] Staging: fbtft: fix space errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1425306048.31561.16.camel@perches.com>
Date:	Mon, 02 Mar 2015 06:20:48 -0800
From:	Joe Perches <joe@...ches.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Matteo Semenzato <mattew8898@...il.com>,
	gregkh@...uxfoundation.org, noralf@...nnes.org,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH] Staging: fbtft: fix space errors

On Mon, 2015-03-02 at 12:37 +0300, Dan Carpenter wrote:
> On Sat, Feb 28, 2015 at 06:59:19AM -0800, Joe Perches wrote:
> > If you're really going to change these, please
> > remove the unnecessary \ line continuations
> > indent the blocks properly and group the blocks
> > more intelligibly.  Maybe something like;
> > 
> > static const int st7735r_init[] = { 
> > 	-1, 0x01,
[]
> > 	-2, 10,
> > 	-3
> > };
> 
> What's the logic here?  Why are we putting the negatives first?

Those are delimiters.  see fbtft-core.c:fbtft_init_display().

As far as I understand:

-1, start of block
-2, millisecond delay after block write
-3, end of blocks

Beyond that, I don't much care.
I just prefer intelligible over apparently random.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/