linux-kernel - Re: [PATCH] Staging: fbtft: fix space errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150302192120.GA4136@nest>
Date:	Mon, 2 Mar 2015 22:21:20 +0300
From:	Andrey Skvortsov <andrej.skvortzov@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	Matteo Semenzato <mattew8898@...il.com>, noralf@...nnes.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: fbtft: fix space errors

On 02 Mar, Joe Perches wrote:
> On Mon, 2015-03-02 at 12:37 +0300, Dan Carpenter wrote:
> > On Sat, Feb 28, 2015 at 06:59:19AM -0800, Joe Perches wrote:
> > > If you're really going to change these, please
> > > remove the unnecessary \ line continuations
> > > indent the blocks properly and group the blocks
> > > more intelligibly.  Maybe something like;
> > > 
> > > static const int st7735r_init[] = { 
> > > 	-1, 0x01,
> []
> > > 	-2, 10,
> > > 	-3
> > > };
> > 
> > What's the logic here?  Why are we putting the negatives first?
> 
> Those are delimiters.  see fbtft-core.c:fbtft_init_display().
> 
> As far as I understand:
> 
> -1, start of block
> -2, millisecond delay after block write
> -3, end of blocks
> 
> Beyond that, I don't much care.
> I just prefer intelligible over apparently random.

If it is correct, then it would be better to replace these magic numbers with meaningful
defines.

-- 
Best regards,
Andrey Skvortsov

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)