linux-kernel - Re: 3.19: device name associates with IRQ's for ahci controllers operating with a single IRQ changed from "ahci?" to "<BDF>"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150302191049.GA8051@htj.duckdns.org>
Date:	Mon, 2 Mar 2015 14:10:49 -0500
From:	Tejun Heo <tj@...nel.org>
To:	Alexander Gordeev <agordeev@...hat.com>
Cc:	Stefan Bader <stefan.bader@...onical.com>,
	Sander Eikelenboom <linux@...elenboom.it>,
	linux-kernel@...r.kernel.org
Subject: Re: 3.19: device name associates with IRQ's for ahci controllers
 operating with a single IRQ changed from "ahci?" to "<BDF>"

On Mon, Mar 02, 2015 at 06:58:10PM +0000, Alexander Gordeev wrote:
> On Mon, Mar 02, 2015 at 12:21:08PM -0500, Tejun Heo wrote:
> > Hello,
> > 
> > On Mon, Feb 16, 2015 at 05:28:42PM +0000, Alexander Gordeev wrote:
> > > The problem dates back to commit 4f37b50 ("libata: Use dev_name() for
> > > request_irq() to distinguish devices"). If the commit is considered valid
> > > then <BDF> still might be legitimate as well. Not sure what is the best
> > > approach here.
> > 
> > What does <BDF> indicate?  Does it successfully identify the device in
> > question?
> 
> I suppose, PCI bus-device-function.
> Yes, it does.

Hmmm... it does stand out like a sore thumb and we probably should use
a more descriptive identifier including the driver name.  4f37b50
("libata: Use dev_name() was fine for the specific platform device as
the device identifier included ide but not generally.  :(

How about driver name followed by device ID?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/