linux-kernel - Re: 3.19: device name associates with IRQ's for ahci controllers operating with a single IRQ changed from "ahci?" to "<BDF>"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <583821471.20150302201100@eikelenboom.it>
Date:	Mon, 2 Mar 2015 20:11:00 +0100
From:	Sander Eikelenboom <linux@...elenboom.it>
To:	Alexander Gordeev <agordeev@...hat.com>
CC:	Tejun Heo <tj@...nel.org>,
	Stefan Bader <stefan.bader@...onical.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: 3.19: device name associates with IRQ's for ahci controllers operating with a single IRQ changed from "ahci?" to "<BDF>"


Monday, March 2, 2015, 7:58:10 PM, you wrote:

> On Mon, Mar 02, 2015 at 12:21:08PM -0500, Tejun Heo wrote:
>> Hello,
>> 
>> On Mon, Feb 16, 2015 at 05:28:42PM +0000, Alexander Gordeev wrote:
>> > The problem dates back to commit 4f37b50 ("libata: Use dev_name() for
>> > request_irq() to distinguish devices"). If the commit is considered valid
>> > then <BDF> still might be legitimate as well. Not sure what is the best
>> > approach here.
>> 
>> What does <BDF> indicate?  Does it successfully identify the device in
>> question?

> I suppose, PCI bus-device-function.
> Yes, it does.

But at least it should be the same for single irq and not single irq,
which at present doesn't seem to be the case.

Apart from that you could also combine the devicetype with the BDF,
like xen-pciback does that looks like this in /proc/interrupts:
  22:     226798          0          0          0          0          0  xen-pirq-ioapic-level  xen-pciback[0000:03:06.0]

--
Sander

>> Thanks.
>> 
>> -- 
>> tejun


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/