linux-kernel - Re: [PATCH 2/4] regulator: core: Expose init_data to of_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Mar 2015 12:50:33 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Bjorn Andersson <bjorn.andersson@...ymobile.com>
Cc:	Chanwoo Choi <cw00.choi@...sung.com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Kumar Gala <galak@...eaurora.org>,
	Lee Jones <lee.jones@...aro.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Rutland <mark.rutland@....com>,
	Pawel Moll <pawel.moll@....com>,
	Rob Herring <robh+dt@...nel.org>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Andy Gross <agross@...eaurora.org>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/4] regulator: core: Expose init_data to of_parse_cb

On Mon, Mar 02, 2015 at 08:25:38PM -0800, Bjorn Andersson wrote:

> Expose the newly created init_data to the driver's parse callback so
> that it can futher enhance it with e.g. constraints of the regulator.

Why would the driver need to do that?  I guess I'll see later on in the
series but the changelog should make that clear.  Drivers aren't
supposed to ever need to look at their init data, modifying the init
data from what the machine provied is usually a red flag.

> This is needed because calling regulator_register() with a of_node and
> of_match will overwrite the passed config->init_data. An alternative way
> would be to merge the parsed init_data with the driver provided one.

Put any explanation as to why the feature is needed in the changelog.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)