linux-kernel - Re: [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Mar 2015 16:37:31 +0000
From:	Alexey Brodkin <Alexey.Brodkin@...opsys.com>
To:	"christian.ruppert@...tech.com" <christian.ruppert@...tech.com>
CC:	"mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Vineet.Gupta1@...opsys.com" <Vineet.Gupta1@...opsys.com>,
	"wsa@...-dreams.de" <wsa@...-dreams.de>,
	"andriy.shevchenko@...ux.intel.com" 
	<andriy.shevchenko@...ux.intel.com>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"christian.ruppert@...lis.com" <christian.ruppert@...lis.com>
Subject: Re: [PATCH] i2c: designware: Suppress error message if
 platform_get_irq() returns -EPROBE_DEFER

Hi Christian,

On Tue, 2015-03-03 at 17:28 +0100, Christian Ruppert wrote:
> On 2015-03-03 16:27, Alexey Brodkin wrote:
> > There's no point in printing error message if platform_get_irq()
> > returns -EPROBE_DEFER because probe deferring subsystem already outputs
> > message in bootlog like this:
> >  --->8---
> >  platform e001d000.i2c: Driver i2c_designware requests probe deferral
> >  --->8---
> > 
> > Moreover in case of probe deferral following message may mislead user:
> >  --->8---
> >  i2c_designware e001d000.i2c: no irq resource?
> >  --->8---
> > even though it's expected that platform_get_irq() may return
> > -EPROBE_DEFER.
> >  
> >  	irq = platform_get_irq(pdev, 0);
> >  	if (irq < 0) {
> > -		dev_err(&pdev->dev, "no irq resource?\n");
> > +		if (irq != -EPROBE_DEFER)
> > +			dev_err(&pdev->dev, "no irq resource?\n");
> 
> Presented like this I wonder if this merits being a dev_err at all.
> Wouldn't dev_dbg be more adequate? This might remove the need for the
> condition and also avoid bothering everyone if something in the platform
> device structures or device tree is not right.
> 
> >  		return irq; /* -ENXIO */
> >  	}

We've just had similar discussion related to DW APB UART with Andy here
https://lkml.org/lkml/2015/3/3/412

So yes probably we may safely remove error message from here completely.

-Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/