linux-kernel - Re: [PATCH] vgaarb: Stub vga_set_legacy_decoding()

Open Source and information security mailing list archives

Message-ID: <1425513109.5200.321.camel@redhat.com>
Date:	Wed, 04 Mar 2015 16:51:49 -0700
From:	Alex Williamson <alex.williamson@...hat.com>
To:	Dave Airlie <airlied@...il.com>
Cc:	Dave Airlie <airlied@...ux.ie>,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] vgaarb: Stub vga_set_legacy_decoding()

On Thu, 2015-03-05 at 09:43 +1000, Dave Airlie wrote:
> On 25 February 2015 at 02:16, Alex Williamson
> <alex.williamson@...hat.com> wrote:
> > vga_set_legacy_decoding() is defined in drivers/gpu/vga/vgaarb.c,
> > which is only compiled with CONFIG_VGA_ARB.  A caller would
> > therefore get an undefined symbol if the VGA arbiter is not
> > enabled.
> 
> Acked-by: Dave Airlie <airlied@...hat.com>

Thanks Dave!  I'll route this through my tree with the commit that uses
it.

> > Signed-off-by: Alex Williamson <alex.williamson@...hat.com>
> > ---
> >
> > I'd like to use this function from vfio-pci to opt-out VGA devices
> > from arbitration if vfio-pci VGA support is disabled.  This helps to
> > keep DRI2 enabled on the host if additional GPUs are installed for
> > VMs and used without VGA support.  I can pull this change in through
> > my tree if someone wants to provide just an ack.  Thanks!
> >
> >  include/linux/vgaarb.h |    5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/include/linux/vgaarb.h b/include/linux/vgaarb.h
> > index c37bd4d..8c3b412 100644
> > --- a/include/linux/vgaarb.h
> > +++ b/include/linux/vgaarb.h
> > @@ -65,8 +65,13 @@ struct pci_dev;
> >   *     out of the arbitration process (and can be safe to take
> >   *     interrupts at any time.
> >   */
> > +#if defined(CONFIG_VGA_ARB)
> >  extern void vga_set_legacy_decoding(struct pci_dev *pdev,
> >                                     unsigned int decodes);
> > +#else
> > +static inline void vga_set_legacy_decoding(struct pci_dev *pdev,
> > +                                          unsigned int decodes) { };
> > +#endif
> >
> >  /**
> >   *     vga_get         - acquire & locks VGA resources
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@...ts.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives