linux-kernel - Re: [PATCH] ftracetest: Don't use non-POSIX exit -1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1425524162.32154.18.camel@ellerman.id.au>
Date:	Thu, 05 Mar 2015 13:56:02 +1100
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	shuahkh@....samsung.com, linux-kernel@...r.kernel.org,
	davej@...emonkey.org.uk, namhyung@...nel.org
Subject: Re: [PATCH] ftracetest: Don't use non-POSIX exit -1

On Wed, 2015-03-04 at 21:26 -0500, Steven Rostedt wrote:
> On Thu,  5 Mar 2015 13:04:02 +1100
> Michael Ellerman <mpe@...erman.id.au> wrote:
> 
> > POSIX says that exit takes an unsigned integer between 0 and 255.
> > 
> > Convert exit -1 to exit 255.
> > 
> 
> Why 255? Why not just exit 1?

I was trying to emulate the current behaviour:

$ /bin/bash
$ exit -1
exit
$ echo $?
255

> Actually, don't we have explicit numbers for exit status?
> 
> /me not looking at the code right now to figure that out.

Yeah looks like it, and some interesting signal handling tricks:

  https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/ftrace/ftracetest#n123

I'll send a new version using "exit $FAIL" ?

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/