linux-kernel - Re: [PATCH] ftracetest: Don't use non-POSIX exit -1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150305090424.3b44b321@gandalf.local.home>
Date:	Thu, 5 Mar 2015 09:04:24 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Michael Ellerman <mpe@...erman.id.au>
Cc:	shuahkh@....samsung.com, linux-kernel@...r.kernel.org,
	davej@...emonkey.org.uk, namhyung@...nel.org
Subject: Re: [PATCH] ftracetest: Don't use non-POSIX exit -1

On Thu, 05 Mar 2015 13:56:02 +1100
Michael Ellerman <mpe@...erman.id.au> wrote:

> > Why 255? Why not just exit 1?
> 
> I was trying to emulate the current behaviour:
> 
> $ /bin/bash
> $ exit -1
> exit
> $ echo $?
> 255

Understood.

> 
> > Actually, don't we have explicit numbers for exit status?
> > 
> > /me not looking at the code right now to figure that out.
> 
> Yeah looks like it, and some interesting signal handling tricks:
> 
>   https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/ftrace/ftracetest#n123
> 
> I'll send a new version using "exit $FAIL" ?

Yep, I figured instead of keeping current behavior, we actually fix it
correctly.

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/