linux-kernel - Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54F83DAE.2060607@redhat.com>
Date:	Thu, 05 Mar 2015 12:27:42 +0100
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Marc Zyngier <marc.zyngier@....com>,
	Eric Auger <eric.auger@...aro.org>,
	"eric.auger@...com" <eric.auger@...com>,
	"christoffer.dall@...aro.org" <christoffer.dall@...aro.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"kvmarm@...ts.cs.columbia.edu" <kvmarm@...ts.cs.columbia.edu>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>
CC:	Andre Przywara <Andre.Przywara@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"patches@...aro.org" <patches@...aro.org>,
	"gleb@...nel.org" <gleb@...nel.org>
Subject: Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support



On 05/03/2015 11:53, Marc Zyngier wrote:
> > +#ifdef CONFIG_HAVE_KVM_IRQFD
> > +	case KVM_CAP_IRQFD:
> > +		r = vgic_present;
> > +		break;
> > +#endif
> 
> Nitpick: we have "select HAVE_KVM_IRQFD", so we can lose the #ifdef-ery.

Alternatively, I've just posted a patch to move the KVM_CAP_IRQFD case
to common code.

vgic_present probably should be replaced by
IS_ENABLED(CONFIG_KVM_ARM_VGIC).  I've sent a patch for this.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/