linux-kernel - Re: [PATCH v2] ARM64: Add new Xilinx ZynqMP SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 05 Mar 2015 15:08:26 +0100
From:	Michal Simek <monstr@...str.eu>
To:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	Michal Simek <michal.simek@...inx.com>
CC:	linux-arm-kernel@...ts.infradead.org,
	Mark Rutland <mark.rutland@....com>,
	Rob Herring <robherring2@...il.com>,
	devicetree@...r.kernel.org, Zach Pfeffer <zachp@...inx.com>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Catalin Marinas <catalin.marinas@....com>,
	Mark Brown <broonie@...aro.org>,
	Will Deacon <will.deacon@....com>,
	linux-kernel@...r.kernel.org, Robert Richter <rrichter@...ium.com>,
	Rob Herring <robh+dt@...nel.org>,
	Kumar Gala <galak@...eaurora.org>,
	Eddie Huang <eddie.huang@...iatek.com>,
	Sören Brinkmann <soren.brinkmann@...inx.com>
Subject: Re: [PATCH v2] ARM64: Add new Xilinx ZynqMP SoC

Hi Thomas,

On 03/05/2015 03:03 PM, Thomas Petazzoni wrote:
> Dear Michal Simek,
> 
> On Thu,  5 Mar 2015 14:53:34 +0100, Michal Simek wrote:
> 
>> +	pmu {
>> +		compatible = "arm,armv8-pmuv3";
>> +		interrupts = <0 143 4>,
>> +			     <0 144 4>,
>> +			     <0 145 4>,
>> +			     <0 146 4>;
> 
> Any reason not to use
> 
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> 
> in order to write the more descriptive:
> 
> 		interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>,
> 			     <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>,
> 			     <GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>,
> 			     <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>;
> 
> And ditto for all other interrupts properties?

I tend to not to use them because it is just hassle when I want
to move DTSes to different project.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)